From e5fd97b8d267b72c41dce72240c913ab7895b460 Mon Sep 17 00:00:00 2001 From: Nick Craig-Wood Date: Mon, 3 Nov 2025 15:51:26 +0000 Subject: [PATCH] bisync: fix failing tests In this commit d240d044c35021d2 check: improved reporting of differences in sizes and contents We adjusted the sense of operations.CheckIdenticalDownload to return true if files are identical as is implied by the name, but we forgot to invert the logic in the bisync DownloadCheckFn which caused lots of tests to fail. --- cmd/bisync/checkfn.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cmd/bisync/checkfn.go b/cmd/bisync/checkfn.go index 6940abee9..bb3f91288 100644 --- a/cmd/bisync/checkfn.go +++ b/cmd/bisync/checkfn.go @@ -130,7 +130,7 @@ func DownloadCheckFn(ctx context.Context, dst, src fs.Object) (equal bool, noHas if err != nil { return true, true, fmt.Errorf("failed to download: %w", err) } - return equal, false, nil + return !equal, false, nil } // check potential conflicts (to avoid renaming if already identical)