From a1f98b49dfa8535467908dce148d106303f9e35a Mon Sep 17 00:00:00 2001 From: max Date: Mon, 17 Aug 2026 04:17:40 +0000 Subject: [PATCH] asyncreader: run the skip-bytes test under the race detector again The test skipped every buffer count above 1 under -race, pointing at golang/go#27070. That issue was closed in September 2018, so the workaround outlived its cause: -race covered 137 of the 681 subtests. Without the guard the race build runs all 681 and passes. --- fs/asyncreader/asyncreader_test.go | 4 ---- 1 file changed, 4 deletions(-) diff --git a/fs/asyncreader/asyncreader_test.go b/fs/asyncreader/asyncreader_test.go index 7c5f9ce97..7e4eeeee5 100644 --- a/fs/asyncreader/asyncreader_test.go +++ b/fs/asyncreader/asyncreader_test.go @@ -13,7 +13,6 @@ import ( "testing/iotest" "time" - "github.com/rclone/rclone/lib/israce" "github.com/rclone/rclone/lib/readers" "github.com/stretchr/testify/assert" "github.com/stretchr/testify/require" @@ -316,9 +315,6 @@ func TestAsyncReaderSkipBytes(t *testing.T) { 8000, len(data), BufferSize, 2 * BufferSize} for buffers := 1; buffers <= 5; buffers++ { - if israce.Enabled && buffers > 1 { - t.Skip("FIXME Skipping further tests with race detector until https://github.com/golang/go/issues/27070 is fixed.") - } t.Run(fmt.Sprintf("%d", buffers), func(t *testing.T) { for _, initialRead := range initialReads { t.Run(fmt.Sprintf("%d", initialRead), func(t *testing.T) {